Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Storybook does not respect BROWSER env var #21473

Merged
merged 5 commits into from
May 22, 2023
Merged

fix: Storybook does not respect BROWSER env var #21473

merged 5 commits into from
May 22, 2023

Commits on Mar 8, 2023

  1. fix: Storybook does not respect BROWSER env var 

    Storybook does not respect BROWSER env var if default browser is not chromium based.
This commit adds a check for the environment variable, and passes it to the open package as an argument if the specified browser is not chromium based.

Closes #21343
    @thtliife
    thtliife committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    7d81483 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. chore: update token permissions to hopefully fix dangerjs action

    @thtliife
    thtliife committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    118ef87 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into next-thtliife

    @ndelangen
    ndelangen committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    4141336 View commit details
    Browse the repository at this point in the history

  3. fix linting

    @ndelangen
    ndelangen committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    fbb1014 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Merge branch 'next' into next

    @thtliife
    thtliife authored May 22, 2023
    Configuration menu
    Copy the full SHA
    25700a2 View commit details
    Browse the repository at this point in the history