-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Raw support for mjs
, jsx
, and tsx
files
#21671
Docs: Raw support for mjs
, jsx
, and tsx
files
#21671
Conversation
I hope it's okay, I'm marking this as ready for review despite a lack of test automation because I'm not sure how to get started testing this feature automatically, as is it can't even be tested manually without making manual modifications to the testing scaffolds. After taking a glance if you could point me in a good direction I'll continue on those parts of the PR. |
Hey @42shadow42 thank you so much for your contribution! Let's involve @ndelangen to help you get started with testing, and @jonniebigodes to chime in regarding possible documentation changes. thanks! |
Hey @ndelangen do you think this is good to (rebase then) merge? |
mjs
, jsx
, and tsx
files
…book into pr/42shadow42/21671 # Conflicts: # code/addons/docs/template/stories/stories-mdx/RawSource.jsx # code/addons/docs/template/stories/stories-mdx/raw-source.non-stories.js
What I did
Enabled support for loading truly raw mjs,jsx, and tsx files by disabling the babel-loader when the raw query is set.
How to test
yarn task --task sandbox --template react-webpack/18-ts
Instead of:
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]