Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixing controls check type issues #21724

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

jungpaeng
Copy link
Contributor

What I did

The Storybook 7.0 documentation had controls that didn't work, so we fixed the documentation.

How to test

No testing is required.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@jungpaeng jungpaeng changed the title docs: Fixing Controls check type issues docs: Fixing controls check type issues Mar 22, 2023
@jonniebigodes
Copy link
Contributor

jonniebigodes commented Mar 27, 2023

@jungpaeng, thanks for taking the time to create this pull request and help us improve our documentation. We appreciate it. To help me review, can you do me a favour and update your branch based on the latest version of the next branch? As some minor changes are required. Let me know once you've done it, and we'll go from there.

Hope you have a great week.

Stay safe

@jungpaeng
Copy link
Contributor Author

@jonniebigodes Hi, I updated based on the next branch of the current storybook.

@jonniebigodes
Copy link
Contributor

@jungpaeng thanks for addressing the feedback so promptly. I've checked this, and it seems that there's something happening with the check control. I tested both variants (the current one documented and the way you're proposing), and both worked out the same way. With that, I'm more than ok to merge this for the time being, as it will make it more idiomatic.

Hope you have a great day.

Stay safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants