Tech: upgrade esbuild, remove watch option from options

[ndelangen]

When I try to start yarn storybook:ui in code it fails with:

It seems like vite is using esbuild 0.17 and we were using esbuild 0.16, and this was causing issues during local development.

I am attempting to fix.

I regenerated the lockfile, this did not help
I tried upgrading esbuild to 0.17, this solved the issue.

It seems like vite is now slower and is logging a lot:
(I didn't touch/change any files as it started)

[socket-security]

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

Package	Bin script	Source
esbuild@0.17.12 (added)	esbuild	code/package.json via esbuild-loader@3.0.1, code/lib/core-common/package.json via esbuild-register@3.4.2, scripts/package.json via tsup@6.7.0
esbuild@0.17.8 (added)	esbuild	code/package.json via @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-rc.6, jest-preset-angular@13.0.1, code/addons/storyshots-puppeteer/package.json via @storybook/addon-storyshots@7.0.0-rc.6, code/frameworks/angular/package.json via @angular-devkit/build-angular@15.2.4, jest-preset-angular@12.2.6
esbuild-wasm@0.17.8 (added)	esbuild	code/package.json via @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-rc.6, jest-preset-angular@13.0.1, code/addons/storyshots-puppeteer/package.json via @storybook/addon-storyshots@7.0.0-rc.6, code/frameworks/angular/package.json via @angular-devkit/build-angular@15.2.4, jest-preset-angular@12.2.6

Pull request report summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script confusion	⚠️ 3 issues
Bin script shell injection	✅ 0 issues
Shell access	✅ 0 issues
Uses eval	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
GitHub dependency	✅ 0 issues
New author	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues
AI detected malware	✅ 0 issues

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore esbuild@0.17.12
• @SocketSecurity ignore esbuild@0.17.8
• @SocketSecurity ignore esbuild-wasm@0.17.8

Powered by socket.dev

[ndelangen]

When i start a sandbox, it doesn't give this long list of HRM updates and warnings about new dependencies optimised.

I noticed 1, and added that to the array.

[IanVS]

When i start a sandbox, it doesn't give this long list of HRM updates and warnings about new dependencies optimised.

How did you trigger that above? Was it during a re-compile or something? Are you saying it's not an issue now?

[ndelangen]

@IanVS I triggered it by running yarn storybook:ui in the code dir.

It's the storybook UI's storybook.
So not a sandbox.

[ndelangen]

@shilman I'm going to merge this then, as this seems the best way forwards.