Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Polyfill global by default #21832

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Vite: Polyfill global by default #21832

merged 1 commit into from
Mar 30, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Mar 30, 2023

Closes #17516

What I did

Storybook will polyfill global, therefore removing the need to add preview-head.html with a workaround

How to test

  1. Run a sandbox for a vite template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Open Storybook in your browser
  3. It should work (without needing preview-head)

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactions-addon relies on polyfilled global (via jest-mock)
2 participants