Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: fix the workflows to generate sandboxes #21912

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Build: fix the workflows to generate sandboxes #21912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1d55cc
fix the workflows
ndelangen Apr 4, 2023
62b771b
add workdir
ndelangen Apr 4, 2023
afb160b
remove the pnp sandbox option, it's broken
ndelangen Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/generate-sandboxes-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
schedule:
- cron: '2 2 */1 * *'
workflow_dispatch:
push:
branches:
- norbert/fix-sandbox-generate-workflow

jobs:
generate:
Expand All @@ -25,9 +28,12 @@ jobs:
- name: Install dependencies
run: node ./scripts/check-dependencies.js
- name: Compile Storybook libraries
run: yarn task --task publish --start-from=auto --no-link
run: yarn task --task compile --start-from=auto --no-link
- name: Publishing to local registry
run: yarn local-registry --publish
working-directory: ./code
- name: Running local registry
run: yarn local-registry --publish --open &
run: yarn local-registry --open &
working-directory: ./code
- name: Wait for registry
run: yarn wait-on http://localhost:6001
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/generate-sandboxes-next.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
schedule:
- cron: '2 2 */1 * *'
workflow_dispatch:
push:
branches:
- norbert/fix-sandbox-generate-workflow

jobs:
generate:
Expand All @@ -25,9 +28,12 @@ jobs:
- name: Install dependencies
run: node ./scripts/check-dependencies.js
- name: Compile Storybook libraries
run: yarn task --task publish --start-from=auto --no-link
run: yarn task --task compile --start-from=auto --no-link
- name: Publishing to local registry
run: yarn local-registry --publish
working-directory: ./code
- name: Running local registry
run: yarn local-registry --publish --open &
run: yarn local-registry --open &
working-directory: ./code
- name: Wait for registry
run: yarn wait-on http://localhost:6001
Expand Down
14 changes: 7 additions & 7 deletions code/lib/cli/src/sandbox-templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,13 +442,13 @@ const internalTemplates = {
},
},
},
'internal/pnp': {
...baseTemplates['cra/default-ts'],
name: 'PNP (cra/default-ts)',
script: 'yarn create react-app . --use-pnp',
isInternal: true,
inDevelopment: true,
},
// 'internal/pnp': {
// ...baseTemplates['cra/default-ts'],
// name: 'PNP (cra/default-ts)',
// script: 'yarn create react-app . --use-pnp',
// isInternal: true,
// inDevelopment: true,
// },
} satisfies Record<`internal/${string}`, Template & { isInternal: true }>;

export const allTemplates: Record<TemplateKey, Template> = {
Expand Down