Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remark slug and remark external links are deprecated #22313

Conversation

MehakFatima24
Copy link

Closes #21838

What I did

I updated the dependencies of the project by replacing the deprecated remark-slug and remark-external-links with rehype-slug and rehype-external-links, respectively. This improves the codebase by using up-to-date and actively maintained packages.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@socket-security
Copy link

socket-security bot commented Apr 28, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
rehype-slug@5.1.0 None +8 wooorm
rehype-external-links@2.0.1 None +2 wooorm
⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@vitejs/plugin-react@4.0.0 2.2.0...4.0.0, 3.1.0...4.0.0 None +0/-25 vitebot

@MehakFatima24 MehakFatima24 marked this pull request as ready for review April 28, 2023 15:45
@MehakFatima24
Copy link
Author

@JReinhold @ndelangen I did something silly 🥲 and accidentally closed my old MR , I have updated this one and tested the sandbox for react-vite and ran the unit tests. Can you please review this?

@JReinhold JReinhold self-requested a review May 1, 2023 14:19
@JReinhold JReinhold self-assigned this May 1, 2023
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A few minor comments, and then we need to upgrade @storybook/mdx2-csf when that gets released, which it should be soon.

@@ -52,7 +52,7 @@
"@rollup/pluginutils": "^4.2.0",
"@storybook/builder-vite": "7.1.0-alpha.10",
"@storybook/react": "7.1.0-alpha.10",
"@vitejs/plugin-react": "^3.0.1",
"@vitejs/plugin-react": "^4.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why you did this, we have a general discussion about the problem, but this is not that easily fixed, so you have to revert it.

(remember to run yarn install afterwards to update the lock file)

Suggested change
"@vitejs/plugin-react": "^4.0.0",
"@vitejs/plugin-react": "^3.0.1",

@@ -212,7 +212,7 @@
"@typescript-eslint/eslint-plugin": "^5.45.0",
"@typescript-eslint/experimental-utils": "^5.45.0",
"@typescript-eslint/parser": "^5.45.0",
"@vitejs/plugin-react": "^2.1.0",
"@vitejs/plugin-react": "^4.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@vitejs/plugin-react": "^4.0.0",
"@vitejs/plugin-react": "^2.1.0",

@JReinhold
Copy link
Contributor

@MehakFatima24 your changes to @storybook/mdx2-csf have been released at v1.1.0, so you should be able to upgrade that dependency in this branch and finally see the changes work :) https://github.com/storybookjs/mdx2-csf/releases/tag/v1.1.0

@shilman
Copy link
Member

shilman commented Jun 12, 2023

@MehakFatima24 @JReinhold what's going on with this one? Any chance we can get it over the line sometime soon?

@MehakFatima24
Copy link
Author

MehakFatima24 commented Jun 12, 2023

@MehakFatima24 @JReinhold what's going on with this one? Any chance we can get it over the line sometime soon?

Hi @shilman , I'd be updating the dependency and testing the changes again today, so we can get this merged.

@JReinhold
Copy link
Contributor

This has gone stale, and it's probably easier to redo it from scratch for anyone that wants this feature in. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remark-slug and remark-external-links are deprecated
5 participants