-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remark slug and remark external links are deprecated #22313
Remark slug and remark external links are deprecated #22313
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
…ark-external-links-are-deprecated
@JReinhold @ndelangen I did something silly 🥲 and accidentally closed my old MR , I have updated this one and tested the sandbox for react-vite and ran the unit tests. Can you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! A few minor comments, and then we need to upgrade @storybook/mdx2-csf
when that gets released, which it should be soon.
@@ -52,7 +52,7 @@ | |||
"@rollup/pluginutils": "^4.2.0", | |||
"@storybook/builder-vite": "7.1.0-alpha.10", | |||
"@storybook/react": "7.1.0-alpha.10", | |||
"@vitejs/plugin-react": "^3.0.1", | |||
"@vitejs/plugin-react": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand why you did this, we have a general discussion about the problem, but this is not that easily fixed, so you have to revert it.
(remember to run yarn install
afterwards to update the lock file)
"@vitejs/plugin-react": "^4.0.0", | |
"@vitejs/plugin-react": "^3.0.1", |
@@ -212,7 +212,7 @@ | |||
"@typescript-eslint/eslint-plugin": "^5.45.0", | |||
"@typescript-eslint/experimental-utils": "^5.45.0", | |||
"@typescript-eslint/parser": "^5.45.0", | |||
"@vitejs/plugin-react": "^2.1.0", | |||
"@vitejs/plugin-react": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@vitejs/plugin-react": "^4.0.0", | |
"@vitejs/plugin-react": "^2.1.0", |
@MehakFatima24 your changes to |
@MehakFatima24 @JReinhold what's going on with this one? Any chance we can get it over the line sometime soon? |
Hi @shilman , I'd be updating the dependency and testing the changes again today, so we can get this merged. |
This has gone stale, and it's probably easier to redo it from scratch for anyone that wants this feature in. Closing. |
Closes #21838
What I did
I updated the dependencies of the project by replacing the deprecated remark-slug and remark-external-links with rehype-slug and rehype-external-links, respectively. This improves the codebase by using up-to-date and actively maintained packages.
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]