Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies.yml to include batch updates for docs dependencies #2252

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Update dependencies.yml to include batch updates for docs dependencies #2252

merged 1 commit into from
Nov 6, 2017

Conversation

davegaeddert
Copy link
Contributor

@Hypnosphi we've added a batch_mode to npm, which you can now use on your docs dependencies which I assume is how you were wanting to do it. I also removed the version tag from the js-lerna actor, since we've now made that the default and pushed a few more updates to it.

I noticed that you're now on weekly builds? One thing that I noticed on my fork (and probably happened to you also) is that the batch lerna actor can timeout with so many updates to make. I was trying to think through some ways to speed that up and am wondering if we can use this: https://yarnpkg.com/en/docs/cli/generate-lock-entry The related question I have is: is your dependency workflow now more tied to yarn workspaces than lerna? Does lerna even matter anymore in terms of managing dependencies for this repo?

@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #2252 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2252   +/-   ##
======================================
  Coverage    22.2%   22.2%           
======================================
  Files         268     268           
  Lines        5872    5872           
  Branches      705     709    +4     
======================================
  Hits         1304    1304           
+ Misses       4019    4016    -3     
- Partials      549     552    +3
Impacted Files Coverage Δ
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
...s/left_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 21.36% <0%> (ø) ⬆️
addons/info/src/components/Props.js 37.2% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
...ponents/left_panel/stories_tree/tree_decorators.js 33.33% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0709fc2...b7ff95f. Read the comment docs.

@Hypnosphi
Copy link
Member

Actually, we use lerna only for publishing now.

I was OK with daily builds, I think I‘ll switch back to it

@Hypnosphi Hypnosphi merged commit 2ff2fbf into storybookjs:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants