Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add JSDoc comments to manager-api APIs #22968

Merged
merged 16 commits into from
Jun 8, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 7, 2023

@tmeasday You asked if we should start adding jsdoc comments, I think you're right.

With the power of some AI, I added this.
I did some manual edits, but overall pretty please with the mostly automated additions.

This will give us a blueprint for how to provide additional instructions for methods, arguments.
One of the cool things for example is we can list some usage examples on methods.

@ndelangen ndelangen requested a review from a team as a code owner June 7, 2023 21:33
@ndelangen ndelangen self-assigned this Jun 7, 2023
@ndelangen ndelangen added maintenance User-facing maintenance tasks core typescript labels Jun 7, 2023
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it @ndelangen

code/lib/manager-api/src/modules/stories.ts Outdated Show resolved Hide resolved
code/lib/manager-api/src/modules/stories.ts Outdated Show resolved Hide resolved
code/lib/manager-api/src/modules/stories.ts Outdated Show resolved Hide resolved
@ndelangen ndelangen merged commit bf6b009 into next Jun 8, 2023
@ndelangen ndelangen deleted the norbert/add-jsdoc-manager-api branch June 8, 2023 09:02
@JReinhold JReinhold changed the title Maintenance: add jsdoc comments to manager-api APIs Maintenance: Add JSDoc comments to manager-api APIs Jun 9, 2023
@JReinhold JReinhold changed the title Maintenance: Add JSDoc comments to manager-api APIs Core: Add JSDoc comments to manager-api APIs Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants