Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove packages' devDependencies that duplicate the root ones #2302

Merged
merged 3 commits into from
Nov 14, 2017

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Nov 13, 2017

Issue: we have a lot of unnecessary devDependencies entries (mostly on react, react-dom, and shelljs). Given that we use a monorepo architecture, it's enough to have those as root devDeps. Among other things, this will lower the pressure on dependencies.io (see #1921 (comment))

I did yarn bootstrap --reset --all, and checked that all the three kitchen sink apps work correctly

@Hypnosphi Hypnosphi added cleanup Minor cleanup style change that won't show up in release changelog maintenance User-facing maintenance tasks labels Nov 13, 2017
@Hypnosphi Hypnosphi requested a review from a team November 13, 2017 23:48
@codecov
Copy link

codecov bot commented Nov 13, 2017

Codecov Report

Merging #2302 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2302   +/-   ##
=======================================
  Coverage   21.19%   21.19%           
=======================================
  Files         283      283           
  Lines        6156     6156           
  Branches      719      721    +2     
=======================================
  Hits         1305     1305           
- Misses       4312     4314    +2     
+ Partials      539      537    -2
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/components/src/navigation/menu_link.js 0% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Info.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.21% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Elements.js 0% <0%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b91af...72cbf6c. Read the comment docs.

@danielduan danielduan merged commit 42cd88a into master Nov 14, 2017
@danielduan danielduan deleted the remove-duplicate-dev-deps branch November 14, 2017 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog dependencies maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants