Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX propwarning on basebutton && ADD style prop on basebutton #2305

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen self-assigned this Nov 14, 2017
@codecov
Copy link

codecov bot commented Nov 14, 2017

Codecov Report

Merging #2305 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2305   +/-   ##
=======================================
  Coverage   21.19%   21.19%           
=======================================
  Files         283      283           
  Lines        6156     6156           
  Branches      731      724    -7     
=======================================
  Hits         1305     1305           
- Misses       4296     4300    +4     
+ Partials      555      551    -4
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/knobs/src/components/PropField.js 10.63% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c7d4a7...556259c. Read the comment docs.

@ndelangen ndelangen requested review from danielduan and a team November 14, 2017 12:50
@danielduan danielduan merged commit 633cf8b into master Nov 14, 2017
@danielduan danielduan deleted the fix-proptype-warning-basebutton branch November 14, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants