Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix parallelism count #23203

Merged
merged 2 commits into from
Jun 24, 2023
Merged

Build: Fix parallelism count #23203

merged 2 commits into from
Jun 24, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jun 23, 2023

Closes #

What I did

Apart from fixing the count, I improved the yarn get-template script so when it fails, it provides a proper answer that guides us with exactly what parallelism values we need put to fix the issue:

image

You can also run the command locally before pushing:

yarn get-template --cadence merged --task test-runner --debug

If you specify a task but not a cadence, it shows that task for all cadences:

image

If you specify a cadence, but not a task, it shows all tasks for that given cadence:

image

If you do not specify anything, it shows every cadence and every task:

image

A future iteration could, instead of logging the information, just automatically update the yml file instead.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged. labels Jun 23, 2023
@yannbf yannbf force-pushed the fix/parallelism-count branch from f82ec7d to 5e1daf8 Compare June 23, 2023 23:05
@yannbf yannbf added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:merged Run the CI jobs that normally run when merged. labels Jun 24, 2023
@yannbf yannbf force-pushed the fix/parallelism-count branch from 5e1daf8 to 7befc4c Compare June 24, 2023 10:14
@ndelangen ndelangen merged commit 472d37f into next Jun 24, 2023
@ndelangen ndelangen deleted the fix/parallelism-count branch June 24, 2023 14:50
@github-actions github-actions bot mentioned this pull request Jun 24, 2023
12 tasks
@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 27, 2023
@github-actions github-actions bot mentioned this pull request Jul 12, 2023
16 tasks
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants