Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document return type of date knob (see #1489) #2332

Merged
merged 2 commits into from
Nov 17, 2017

Conversation

grncdr
Copy link
Contributor

@grncdr grncdr commented Nov 17, 2017

Issue:

What I did

Updated documentation of date knob according to the details in #1489

How to test

Is this testable with jest or storyshots?

No

Does this need a new example in the kitchen sink apps?

No

Does this need an update to the documentation?

No

@codecov
Copy link

codecov bot commented Nov 17, 2017

Codecov Report

Merging #2332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2332   +/-   ##
=======================================
  Coverage   21.19%   21.19%           
=======================================
  Files         283      283           
  Lines        6156     6156           
  Branches      722      736   +14     
=======================================
  Hits         1305     1305           
+ Misses       4296     4271   -25     
- Partials      555      580   +25
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
.../src/manager/containers/CommentsPanel/dataStore.js 34.04% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Info.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf815e...96c4226. Read the comment docs.

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Hypnosphi Hypnosphi merged commit e7cf067 into storybookjs:master Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants