Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize @storybook/addon-storyshots peerDependencies #2337

Merged
merged 4 commits into from
Dec 4, 2017

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Nov 18, 2017

Issue: #2303

What I did

Moved babel-core and @storybook/channels to direct dependencies. Removed @storybook/react peer dependency as storyshots may be used with @storybook/react-native as well

How to test

Change babel-core and @storybook/channels in addons/storyshots/package.json to some earlier versions (without caret), like this:

"@storybook/channels": "3.2.15",
"babel-core": "6.25.0",

This way @storybook/addon-storyshots will get its own instances of those packages.

Run

yarn bootstrap --core
yarn test --core # this one uses storyshots for cra-kitchen-sink

@Hypnosphi Hypnosphi added cleanup Minor cleanup style change that won't show up in release changelog dependencies addon: storyshots labels Nov 18, 2017
@codecov
Copy link

codecov bot commented Nov 18, 2017

Codecov Report

Merging #2337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2337   +/-   ##
=======================================
  Coverage   16.64%   16.64%           
=======================================
  Files         302      302           
  Lines        7769     7769           
  Branches      778      779    +1     
=======================================
  Hits         1293     1293           
+ Misses       5861     5836   -25     
- Partials      615      640   +25
Impacted Files Coverage Δ
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/info/src/components/Story.js 30.8% <0%> (ø) ⬆️
addons/jest/src/components/Result.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.63% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Info.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
...t-native/src/preview/components/StoryView/index.js 0% <0%> (ø) ⬆️
addons/info/src/components/Props.js 37.2% <0%> (ø) ⬆️
addons/knobs/src/components/types/Date/index.js 23.52% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e745c...6dfbd3f. Read the comment docs.

@Hypnosphi Hypnosphi requested a review from a team November 24, 2017 22:04
@Hypnosphi Hypnosphi self-assigned this Dec 4, 2017
@Hypnosphi Hypnosphi merged commit 3b03c7e into master Dec 4, 2017
@Hypnosphi Hypnosphi deleted the optimize-storyshots-peers branch December 4, 2017 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: storyshots cleanup Minor cleanup style change that won't show up in release changelog dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants