Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Blocks: Add title to Meta prop types #23370

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Doc Blocks: Add title to Meta prop types #23370

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5adcfc9
issue#22910
iqbalcodes6602 Jul 8, 2023
7cac275
Merge branch 'next' into iqbal
iqbalcodes6602 Jul 10, 2023
993f506
Merge branch 'storybookjs:next' into iqbal
iqbalcodes6602 Jul 11, 2023
b59dc15
Merge branch 'storybookjs:next' into iqbal
iqbalcodes6602 Jul 12, 2023
31cfea1
Update Meta.tsx, removed the destructuring of title
iqbalcodes6602 Jul 12, 2023
b55179f
Merge branch 'storybookjs:next' into iqbal
iqbalcodes6602 Jul 12, 2023
d6077ee
Merge branch 'next' into iqbal
JReinhold Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/ui/blocks/src/blocks/Meta.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ import type { BaseAnnotations, ModuleExports } from '@storybook/types';
import { Anchor } from './Anchor';
import { DocsContext } from './DocsContext';

type MetaProps = BaseAnnotations & { of?: ModuleExports };
type MetaProps = BaseAnnotations & { of?: ModuleExports; title?: string };

/**
* This component is used to declare component metadata in docs
* and gets transformed into a default export underneath the hood.
*/
export const Meta: FC<MetaProps> = ({ of }) => {
export const Meta: FC<MetaProps> = ({ of, title }) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to destructure the title out of props here as it's never being used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MWhite-22 thank u for responding. I have updated this please can you consider this PR for merging so that i can get my first PR merged.

const context = useContext(DocsContext);
if (of) {
context.referenceMeta(of, true);
Expand Down