Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features: For 7.2 #23446

Merged
merged 252 commits into from
Jul 19, 2023
Merged

Features: For 7.2 #23446

merged 252 commits into from
Jul 19, 2023

Conversation

ndelangen
Copy link
Member

This has changes that have been approved, but were too risky or timing wise would not fit in 7.1.

ndelangen and others added 30 commits July 3, 2023 22:46
… split into separate types & use overloads for improved type-safety
Co-authored-by: Valentin Palkovic <valentin@chromatic.com>
@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author ssri 8.0.1

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore ssri@8.0.1

@ndelangen ndelangen added ci:daily Run the CI jobs that normally run in the daily job. and removed ci: do not merge ci:normal labels Jul 19, 2023
MIGRATION.md Outdated Show resolved Hide resolved
Co-authored-by: Yann Braga <yannbf@gmail.com>
args: {
...Base.args,
value:
'Self ocean ultimate reason faith virtues evil eternal-return moral strong superiority. Society will christian god holiest evil virtues ultimate salvation aversion victorious strong eternal-return. Ascetic pious hope selfish battle pinnacle revaluation passion ocean passion chaos reason intentions. Hope hatred pious superiority ascetic chaos ultimate mountains ideal. Superiority good abstract hatred holiest passion ultimate evil inexpedient joy. Salvation war salvation ideal decieve good law ascetic hatred transvaluation horror good. Zarathustra aversion pious truth burying evil inexpedient spirit virtues virtues hope salvation transvaluation. Enlightenment chaos ascetic salvation god holiest play marvelous oneself ocean. Enlightenment faithful dead truth insofar fearful madness love.Inexpedient war hatred superiority disgust justice superiority. Chaos justice contradict christian decieve god. Revaluation suicide hope enlightenment decrepit truth hatred insofar gains sexuality merciful ocean revaluation depths. Revaluation ocean superiority endless of evil horror. Ultimate salvation joy good good endless will horror aversion superiority depths. Evil hatred ideal pious joy reason.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this just use a basic lorem ipsum instead?

Copy link
Member Author

@ndelangen ndelangen Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdedreuille what do you think, doesn't feel like a blocker to me. Is this something you could put on your todo-list to improve?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a stories file. It doesn't matter the content I would say. Let's not merge something in the codebase with words like suicide.

Here's some content to save you time:


Praesent vitae dignissim felis. Nam ultricies accumsan purus, in auctor sapien egestas sit amet. Sed fermentum molestie est, quis suscipit tellus. In congue sem vel enim gravida, et egestas eros tempor. Quisque eu est tempus, maximus justo eget, semper magna. Vestibulum tempor ex et nisi dignissim suscipit. Nullam ullamcorper erat sit amet lorem maximus porta. Phasellus ullamcorper sodales diam, sed egestas urna maximus eget. Donec quis laoreet ipsum, vitae efficitur enim.

Integer in felis mi. Nulla aliquet lorem sit amet tortor pretium, ac porttitor ante laoreet. Ut tincidunt mauris accumsan sem faucibus consectetur. Fusce sed ante eleifend, bibendum nisl vel, interdum augue. Nullam quis pulvinar neque, eu dapibus orci. In ullamcorper hendrerit urna a blandit. Ut ante est, sagittis non mollis non, dapibus quis ligula. Duis volutpat nulla est, quis gravida eros posuere nec. Sed id sollicitudin arcu, et porttitor magna. Proin lacinia, arcu interdum dapibus volutpat, enim velit sollicitudin urna, eget gravida nisi dolor et felis. Praesent non sem ac lacus dictum convallis. Suspendisse tristique est at lectus dapibus tristique. Nam nisi lacus, interdum nec nulla vitae, euismod aliquet nunc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No a blocker but I'll update it in a separate PR. My bad.

@ndelangen ndelangen changed the title Future: 7.2 branch Features: For 7.2 Jul 19, 2023
@ndelangen ndelangen merged commit 26e4d5e into next Jul 19, 2023
@ndelangen ndelangen deleted the release/7.2 branch July 19, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants