Fix HMR by saving the preview frame URL as the story changes. #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure where we are at in the release cycle; this could go straight out if you prefer. |
This was referenced Nov 22, 2017
Codecov Report
@@ Coverage Diff @@
## release/3.3 #2349 +/- ##
===============================================
- Coverage 22.8% 22.75% -0.06%
===============================================
Files 326 326
Lines 6752 6767 +15
Branches 836 845 +9
===============================================
Hits 1540 1540
- Misses 4601 4607 +6
- Partials 611 620 +9
Continue to review full report at Codecov.
|
|
If we decide to have it on master, we can try the cherry-picking approach I proposed for future releases |
shilman
changed the title
|
I am going to be so happy once this is released 👍 |
|
@RobinMalfait this is released as |
tmeasday
added a commit
that referenced
this pull request
Jan 3, 2018
This didn't apply at all cleanly as it involved adding code to each framework's `init.js`, which was removed in the refactor. Here we do better; we simply abstract the job of URL<->redux store syncing to the core library.
tmeasday
added a commit
that referenced
this pull request
Jan 3, 2018
This didn't apply at all cleanly as it involved adding code to each framework's `init.js`, which was removed in the refactor. Here we do better; we simply abstract the job of URL<->redux store syncing to the core library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when there are problems with HMR, we end up doing a
hard-reload of the preview iframe, whilst leaving the main window.
As the preview iframe didn't change its URL ever, this led to problems
where the old (usually original) story was loaded in such circumstances.
Issue:
See #614 and #1328 -- and possibly some more, I'll have a hunt through the issue list.
What I did
use
pushStateto change the preview's URL as stories change.How to test
See the repro on #614
Is this testable with jest or storyshots?
No
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
No
If your answer is yes to any of these, please make sure to include it in your PR.