Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Fix svgr snippet in Next.js docs #23621

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jul 26, 2023

Closes #23620

What I did

There was an issue in the SVGR recipe for Next.js in the README. This PR fixes the issue!

How to test

Check the code, try it in a Next.js project (I did)

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added documentation ci:docs Run the CI jobs for documentation checks only. labels Jul 26, 2023
@yannbf yannbf changed the title fix svgr snippet in nextjs docs Documentation: Fix svgr snippet in Next.js docs Jul 26, 2023
@yannbf yannbf merged commit 9366791 into next Aug 15, 2023
15 checks passed
@yannbf yannbf deleted the yann/fix-nextjs-docs-snippet branch August 15, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot read properties of undefined (reading ‘test’)
2 participants