Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addon-actions in legacy Android browser #2365

Merged
merged 4 commits into from
Nov 29, 2017
Merged

Conversation

Hypnosphi
Copy link
Member

Issue: #2324

What I did

Added a fallback to default "action" function name when it's not configurable (as contrary to the spec)

How to test

Open CRNA app in Android 4.4 emulator

I also moved addon-actions storybook to cra-kitchen-sink

@codecov
Copy link

codecov bot commented Nov 24, 2017

Codecov Report

Merging #2365 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
+ Coverage   19.92%   19.93%   +0.01%     
==========================================
  Files         293      293              
  Lines        6485     6486       +1     
  Branches      754      756       +2     
==========================================
+ Hits         1292     1293       +1     
+ Misses       4625     4600      -25     
- Partials      568      593      +25
Impacted Files Coverage Δ
addons/actions/src/preview.js 52.94% <100%> (+2.94%) ⬆️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
...s/left_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 41.41% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Rules.js 0% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb86e68...b8c8852. Read the comment docs.

@Ragnar-H
Copy link

@Hypnosphi anything I can do help here?

Got hit by #2324 recently

@Hypnosphi Hypnosphi requested a review from a team November 29, 2017 11:24
@tmeasday
Copy link
Member

Look reasonable to me. I don't have an android setup to easily test this though.

@Hypnosphi Hypnosphi merged commit 34608bf into master Nov 29, 2017
@Hypnosphi Hypnosphi deleted the fix-actions-android branch November 29, 2017 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants