-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Updates documentation and examples for Highlight #23830
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonniebigodes
added
documentation
addon: highlight
ci:docs
Run the CI jobs for documentation checks only.
labels
Aug 14, 2023
jonniebigodes
requested review from
valentinpalkovic and
kylegach
as code owners
August 14, 2023 14:02
kylegach
reviewed
Aug 14, 2023
kylegach
reviewed
Aug 14, 2023
kylegach
reviewed
Aug 14, 2023
kylegach
reviewed
Aug 14, 2023
kylegach
reviewed
Aug 14, 2023
kylegach
reviewed
Aug 14, 2023
kylegach
reviewed
Aug 14, 2023
kylegach
reviewed
Aug 14, 2023
kylegach
reviewed
Aug 14, 2023
yannbf
reviewed
Aug 22, 2023
yannbf
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic 👏 thanks a lot!
This was referenced Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23487
What I did
With this pull request the official documentation for the Highlight addon and the corresponding package Readme were updated to the current state of Storybook.
What was done:
@yannbf I left the
ci:docs
label as this is technically a documentation update, and unsure if there are any others required for this case. Let me know and we'll go from thereHow to test
Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>