Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Categorize legacy build options error #24014

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 30, 2023

Closes #24006

What I did

Used the error categorization framework on a common angular issue, and updated outdated docs and links

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

No need, it's been thoroughly tested.

You can create an angular sandbox, then replace the storybook scripts to use storybook dev instead of ng, and the error should be thrown once you run Storybook.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf changed the title categorize angular legacy build options error Angular: Categorize legacy build options error Aug 30, 2023
@yannbf yannbf added the cli label Aug 30, 2023
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yannbf This is shaping up nicely and looks good on my end. Hopefully, in the near future, we'll have the documentation extended to feature the frameworks we support and have the links pointing at them instead of the Readmes. I'm approving this to unblock your work and get this out when possible.

@yannbf yannbf merged commit 0a81127 into next Sep 5, 2023
15 checks passed
@yannbf yannbf deleted the yann/angular-browsertarget-error branch September 5, 2023 14:10
@github-actions github-actions bot mentioned this pull request Sep 5, 2023
25 tasks
@yannbf yannbf mentioned this pull request Oct 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: angularBrowserTarget is undefined
3 participants