Manager: Enable refs filtered via experimental_setFilter

[ndelangen]

Closes https://linear.app/chromaui/issue/AP-3683/possible-to-filter-out-all-stories-with-no-way-to-disable

What I did

I've experimented with keeping the originally passed index/data from refs around in state, so that calling setRef with the previous data will cause it to re-run the filters

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

I ran the following manual test:

Add this to .storybook/main.ts:

  refs: {
    '@manager': {
      title: 'Angular',
      url: 'https://6322ce6af69825592bbb28fc-ltmgncxxqv.chromatic.com',
    },
  },

Then make a UI change.

Add the '@chromaui/addon-visual-tests'-addon.

Now make a UI change.

Now run a build.

And click on the filter button in the bottom left.

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

[tmeasday]

What does the whole sidebar look like when a ref is filtered away? Is it possible to get a story for this state?

[tmeasday]

@ndelangen thanks for adding those.

Perhaps add a story where the main SB is filtered, but still has data, but the ref is empty. That is the likely scenario with the VT addon right? Do we really want to show "this ref is empty, bla bla" in that case? Should we check with @cdedreuille or @MichaelArestad about that?

[ndelangen]

@tmeasday On the sidebar's component there is no filtering, there's only a pre-filtered index.
Either the index has items, or it does not.
Sure I can create a story that combines a main index, with items with an ref whom's index is empty..

I know it doesn't display quite like @MichaelArestad would want it to display, I don't think empty refs were ever designed, in fact I doubt empty main's were ever given a design eye.

It's a bit of a balancing act on how much risky changes we want to make on storybook's side, because do we want to make such changes in a patch version 🤔
As I eluded to here: #24211 (comment) I feel this PR is possibly making a bit too many changes for a patch release.

I was hoping to get this reviewed and merged in the patch release of yesterday.

[MichaelArestad]

We do have a couple empty state designs to draw inspiration from:

And maybe this one:

Seeing a story of this state would help me out.