Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-links: Fix stories #24400

Merged
merged 9 commits into from
Apr 24, 2024
Merged

Addon-links: Fix stories #24400

merged 9 commits into from
Apr 24, 2024

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Oct 6, 2023

What I did

I noticed the stories for addon-links were broken, so I fixed them, including adding a few more cases and removing some (scroll) that aren't relevant in 7.0.

These need E2E to be actually useful, but this is as far as I got right now.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Go through the stories in the published storybook and see that the links work.

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@JReinhold JReinhold requested a review from yannbf as a code owner October 6, 2023 13:27
@JReinhold JReinhold self-assigned this Oct 6, 2023
@JReinhold JReinhold added addon: links build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Oct 6, 2023
Copy link

nx-cloud bot commented Apr 24, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit caf3f2a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JReinhold
Copy link
Contributor Author

Can't believe it's already been 6 months since I opened this. 😱

@JReinhold JReinhold merged commit 18e298a into next Apr 24, 2024
105 of 107 checks passed
@JReinhold JReinhold deleted the fix-links-stories branch April 24, 2024 19:10
@github-actions github-actions bot mentioned this pull request May 3, 2024
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: links build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants