Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Allow loading standalone directives #24448

Conversation

osnoser1
Copy link
Contributor

@osnoser1 osnoser1 commented Oct 12, 2023

Closes #23937
Closes #23494

What I did

  • Allow loading standalone angular directives.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  • With the unit test is enough.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

PD: Thanks to @walkadaw for the suggestion, I tested the suggested change in my local project and it worked!

@osnoser1
Copy link
Contributor Author

Hi @valentinpalkovic, I fixed the lint problem but I don't know why the ci/circleci: create-sandboxes step failed

@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented Oct 12, 2023

This is unrelated to your PR. I just messed up with the sandboxes for 10 minutes. Should be fixed in the next 30 minutes or so :)

Edit: Fixed. I will reran the CI job.

@valentinpalkovic valentinpalkovic added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:normal labels Oct 12, 2023
@valentinpalkovic valentinpalkovic changed the title fix: allow loading standalone directives Angular: Allow loading standalone directives Oct 13, 2023
@valentinpalkovic valentinpalkovic merged commit 048272f into storybookjs:next Oct 13, 2023
9 checks passed
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
7 tasks
@osnoser1 osnoser1 deleted the bugfix/standalone-angular-directives branch October 13, 2023 10:02
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
7 tasks
@yannbf yannbf mentioned this pull request Oct 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Angular Decorator standalone [Bug]: Angular Standalone Directive & Storybook
2 participants