Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native: Fix errors on compose story #25906

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Feb 5, 2024

cherry picked changes from #25894

Closes #

What I did

minimum changes to not error when document doesn't exist

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

see the repro here

https://github.com/dannyhw/rn-sb-test-repro

see components/Button/Button.test.tsx

  1. run yarn install
  2. yarn test
image

If I just update getSelectionSpecifierFromPath then I get the webview error

image

after making these same changes in the nodemodules tests pass

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@dannyhw dannyhw changed the base branch from next to main February 5, 2024 11:12
@dannyhw dannyhw changed the title dannyhw/fix compose story tests v2 React Native: Fix errors on compose story Feb 5, 2024
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot <3

@yannbf yannbf merged commit f4dd3f5 into main Feb 5, 2024
68 of 77 checks passed
@yannbf yannbf deleted the dannyhw/fix-compose-story-tests-v2 branch February 5, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants