Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Upgrade eslint-plugin-storybook #26064

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

ndelangen
Copy link
Member

What I did

I fixed an issue: #21115 via a fix upstream in the eslint plugin. Upgrading will get rid of the issue for uds locally.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

I tested this locally on my own machine via a sandbox story (upgrading and downgrading)

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:normal labels Feb 16, 2024
@ndelangen ndelangen self-assigned this Feb 16, 2024
@ndelangen ndelangen marked this pull request as ready for review February 16, 2024 12:36
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eslint-plugin-storybook@0.8.0 Transitive: environment, eval, filesystem, shell, unsafe +117 45.6 MB

🚮 Removed packages: npm/eslint-plugin-storybook@0.6.15

View full report↗︎

@ndelangen ndelangen merged commit 31e3d9c into next Feb 16, 2024
68 of 74 checks passed
@ndelangen ndelangen deleted the norbert/upgrade-eslint-plugin-storybook branch February 16, 2024 12:59
@github-actions github-actions bot mentioned this pull request Feb 17, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant