Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add addon removal telemetry #26077

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 17, 2024

Closes N/A

What I did

Adds telemetry for addon removal, either from the CLI or from addons

Checklist for Contributors

Testing

Build & run the CLI in a project with telemetry debugging enabled

STORYBOOK_TELEMETRY_DEBUG=true path/to/lib/cli/dist/index.js remove @storybook/addon-links

🦋 Canary release

This pull request has been released as version 0.0.0-pr-26077-sha-aea7ea3d. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26077-sha-aea7ea3d sandbox or in an existing project with npx storybook@0.0.0-pr-26077-sha-aea7ea3d upgrade.

More information
Published version 0.0.0-pr-26077-sha-aea7ea3d
Triggered by @shilman
Repository storybookjs/storybook
Branch shilman/addon-removal-telemetry
Commit aea7ea3d
Datetime Mon Feb 19 00:01:32 UTC 2024 (1708300892)
Workflow run 7952606942

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26077

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. QA-ed and it worked well!

@shilman shilman merged commit a36c4ed into next Feb 19, 2024
59 checks passed
@shilman shilman deleted the shilman/addon-removal-telemetry branch February 19, 2024 09:30
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants