Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Remove the logging to file feature from autoblockers #26100

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Feb 19, 2024

Closes #26097

What I did

The issue describes that all info should be in the terminal, so the logfile is pointless.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  • set a up a sandbox
  • change the sandbox so it triggers an autoblocker (adding storyStoreV7 feature flag is 1 way
  • try to upgrade the sandbox by manually invoking the the CLI on the sandbox
  • expect there to not be a log file generated
  • expect all the information to be in the terminal

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-26100-sha-c827d17a. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26100-sha-c827d17a sandbox or in an existing project with npx storybook@0.0.0-pr-26100-sha-c827d17a upgrade.

More information
Published version 0.0.0-pr-26100-sha-c827d17a
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch norbert/remove-logging-feature-from-autoblockers
Commit c827d17a
Datetime Tue Feb 20 10:51:14 UTC 2024 (1708426274)
Workflow run 7972285584

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26100

@ndelangen ndelangen marked this pull request as ready for review February 20, 2024 09:13
@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented Feb 20, 2024

LGTM Code-Wise. I haven't tested it, though.

@ndelangen ndelangen merged commit b7451ae into next Feb 20, 2024
63 of 64 checks passed
@ndelangen ndelangen deleted the norbert/remove-logging-feature-from-autoblockers branch February 20, 2024 16:15
@github-actions github-actions bot mentioned this pull request Feb 20, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: Show steps to fix autoblockers in the CLI
2 participants