Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte: Add experimental portable stories support #26349

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Mar 6, 2024

Closes #25878

What I did

This PR introduces the portable stories API to Svelte. It works slightly different than in other renderers, because of how Svelte testing libraries expect their components. Mostly because the portable story provides Component and props properties to be used in the test.

// Button.test.ts
import { test } from 'vitest';
import { render } from '@testing-library/svelte';
import { composeStory } from '@storybook/svelte';

import meta, { Primary } from './Button.stories';

test('renders and executes the play function', async () => {
  const PrimaryStory = composeStory(Primary, meta);

  // First, render the story
  render(PrimaryStory.Component, PrimaryStory.props);

  // Then, execute the play function
  await PrimaryStory.play();
});

There are a few limitations though. Users can't pass custom props to their components in the test like they normally would with Svelte components directly:

// ❌ This is not possible
render(PrimaryStory.Component, { ...Primary.props, foo: 'bar' });

They can only get the component to render with props that come from args. If they really want to provide custom props, they should do it while composing the story:

import { composeStory } from '@storybook/svelte';
import meta, { Primary } from './Button.stories';

// ✅ This is possible
const PrimaryStory = composeStory({ ...Primary, args: {...Primary.args, foo: 'bar' } }, meta);

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf changed the base branch from next to feature/portable-stories-improvements March 6, 2024 11:44
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","build","dependencies"]

🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

🚫 PR title must be in the format of "Area: Summary", With both Area and Summary starting with a capital letter Good examples: - "Docs: Describe Canvas Doc Block" - "Svelte: Support Svelte v4" Bad examples: - "add new api docs" - "fix: Svelte 4 support" - "Vue: improve docs"

Generated by 🚫 dangerJS against b2d7c40

@yannbf yannbf force-pushed the feature/portable-stories-svelte-renderer branch from b2d7c40 to 1d47ca3 Compare March 6, 2024 11:46
Copy link

nx-cloud bot commented Mar 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 184e870. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf marked this pull request as ready for review March 12, 2024 17:16
- Better differentiate Svelte's API
Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good!

I pushed a commit to better call out the unique way Svelte needs to override props for an individual story.

@yannbf yannbf changed the title Add support for portable stories in Svelte Svelte: Add experimental portable stories support Mar 14, 2024
@yannbf yannbf force-pushed the feature/portable-stories-svelte-renderer branch from e3ec118 to f225bea Compare March 14, 2024 09:41
@yannbf yannbf merged commit fb1a02e into feature/portable-stories-improvements Mar 18, 2024
56 of 59 checks passed
@yannbf yannbf deleted the feature/portable-stories-svelte-renderer branch March 18, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portable stories - Create compose functions for Svelte
4 participants