-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte: Add experimental portable stories support #26349
Svelte: Add experimental portable stories support #26349
Conversation
|
b2d7c40
to
1d47ca3
Compare
code/renderers/svelte/src/__test__/composeStories/portable-stories.test.ts
Outdated
Show resolved
Hide resolved
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 184e870. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
…table-stories-svelte-renderer
…table-stories-svelte-renderer
- Better differentiate Svelte's API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good!
I pushed a commit to better call out the unique way Svelte needs to override props for an individual story.
docs/snippets/svelte/portable-stories-vitest-compose-story.ts.mdx
Outdated
Show resolved
Hide resolved
…table-stories-svelte-renderer
…table-stories-svelte-renderer
Co-authored-by: Jeppe Reinhold <jeppe@chromatic.com>
e3ec118
to
f225bea
Compare
…table-stories-svelte-renderer
…table-stories-svelte-renderer
…table-stories-svelte-renderer
fb1a02e
into
feature/portable-stories-improvements
Closes #25878
What I did
This PR introduces the portable stories API to Svelte. It works slightly different than in other renderers, because of how Svelte testing libraries expect their components. Mostly because the portable story provides
Component
andprops
properties to be used in the test.There are a few limitations though. Users can't pass custom props to their components in the test like they normally would with Svelte components directly:
They can only get the component to render with props that come from args. If they really want to provide custom props, they should do it while composing the story:
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>