Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tooling: Set version to 8.0.0 #26434

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Mar 12, 2024

What I did

next is currently broken because it's on 8.1.0-alpha.0 which hasn't been released. If we get next "back" to 8.0.0 and then trigger a new preminor release with the usual release PR, we'll release a new 8.1.0-alpha.0 using the regular workflow for releasing prereleases. So when this is merged, we'll release a new prerelease.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@JReinhold JReinhold requested a review from shilman March 12, 2024 07:47
@JReinhold JReinhold self-assigned this Mar 12, 2024
@JReinhold JReinhold added build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only. labels Mar 12, 2024
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but how do we avoid this next time?

Copy link

nx-cloud bot commented Mar 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ccb175d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JReinhold JReinhold marked this pull request as ready for review March 12, 2024 08:01
@JReinhold JReinhold merged commit 7dc7c2e into next Mar 12, 2024
23 of 29 checks passed
@JReinhold JReinhold deleted the jeppe/fix-next-version branch March 12, 2024 08:01
@JReinhold
Copy link
Contributor Author

JReinhold commented Mar 12, 2024

@shilman the publish workflow automatically bumbed next to 8.1.0-alpha.0 without releasing it, but that wasn't enough because it also needed to release. @ndelangen and I have discussed different solutions:

  1. Don't do any bumping at all, next would then have stayed on 8.0.0-rc.5 Whenever there was something new to release, we'd just trigger with preminor and release as usual.
  2. Instead of bumping the versions on next, we'd do an actual (empty) release of 8.1.0-alpha.0, (that will automatically get back to next as all prereleases are.
  3. Fix the Verdaccio problem so we don't need versions to be released for sandboxes to work.

@ndelangen and I think we should go with 1+3 optionally. Considering the most recent rc release is always identical to the stable release, it's okay that next stays on 8.0.0-rc.X until there's new stuff, and users using the next dist-tag won't miss out on much, even though they are technically "behind" the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants