CLI: Add yarn1 package manager fallback for init in empty directory #26500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpty directory with yarn1
valentinpalkovic
changed the title
valentinpalkovic
added
bug
ci:daily
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4eef9b4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
shilman
approved these changes
Mar 17, 2024
|
@valentinpalkovic why did you run |
15 tasks
|
Because the |
|
Aha! Thanks for clarifying 🤦♂️ |
valentinpalkovic
added
the
patch:yes
storybook-bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
…1-while-init CLI: Introduce package manager fallback for initializing Storybook in an empty directory with yarn1 (cherry picked from commit c0fdb3e)
Merged
11 tasks
shilman
changed the title
shilman
changed the title
storybook-bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
…1-while-init CLI: Introduce package manager fallback for initializing Storybook in an empty directory with yarn1 (cherry picked from commit c0fdb3e)
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26480
What I did
I have introduced a package manager fallback from yarn1 to npm in cases where Storybook is initialized into an empty directory. Due to hoisting issues in yarn1, the framework's initialization already fails, and the
initprocess exited with an error.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
mkdir empty-directory && cd ./empty-directorytouch yarn.lockmkdir nested && cd ./nestednpx storybook@0.0.0-pr-26500-sha-4eef9b4c initDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-26500-sha-4eef9b4c. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-26500-sha-4eef9b4c sandboxor in an existing project withnpx storybook@0.0.0-pr-26500-sha-4eef9b4c upgrade.More information
0.0.0-pr-26500-sha-4eef9b4cvalentin/use-npm-over-yarn1-while-init4eef9b4c1710427036)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26500