Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix parallelism for check and compile command on CI #26678

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

valentinpalkovic
Copy link
Contributor

Closes N/A

What I did

Fixed parallelism for check and compile command on CI

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic added build Internal-facing build tooling & test updates ci:normal labels Mar 28, 2024
@valentinpalkovic valentinpalkovic self-assigned this Mar 28, 2024
@valentinpalkovic valentinpalkovic marked this pull request as ready for review March 28, 2024 10:01
Copy link

nx-cloud bot commented Mar 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fdad84e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic merged commit 663194c into next Mar 28, 2024
58 of 61 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-ci-3 branch March 28, 2024 11:03
@github-actions github-actions bot mentioned this pull request Mar 28, 2024
15 tasks
@JReinhold JReinhold added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 11, 2024
This was referenced Apr 11, 2024
@vanessayuenn vanessayuenn added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 11, 2024
This was referenced Apr 11, 2024
shilman pushed a commit that referenced this pull request Apr 16, 2024
CI: Fix parallelism for check and compile command on CI
(cherry picked from commit 663194c)
yannbf pushed a commit that referenced this pull request Apr 19, 2024
CI: Fix parallelism for check and compile command on CI
(cherry picked from commit 663194c)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants