-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js: Fix next/font usage on Windows machines #26700
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e40d784. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
Hi Valentine. |
Hi @sdandrader, I plan to release this fix tomorrow (8.0.6). |
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
…windows Next.js: Fix next/font usage on Windows machines (cherry picked from commit b50c241)
Closes #26450, closes #26699
What I did
next/local/font
ornext/google/font
weren't usable on Windows machines. This is now fixed.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
nextjs/default-js
sandbox locally on a Windows machineFont
story and verify it properly displays the Google font.storybook/main.js
and add the following setting:Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>