Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Fix next/font usage on Windows machines #26700

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Mar 31, 2024

Closes #26450, closes #26699

What I did

next/local/font or next/google/font weren't usable on Windows machines. This is now fixed.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run the nextjs/default-js sandbox locally on a Windows machine
  2. Visit the Font story and verify it properly displays the Google font
  3. Adjust your .storybook/main.js and add the following setting:
staticDirs: [
    '..\\public',
+    {
+      from: '../src/stories/frameworks/nextjs_nextjs-default-js',
+      to: 'src/stories/frameworks/nextjs_nextjs-default-js',
    },
  ],
4. Start Storybook and verify the local font gets properly displayed in the `Font` story.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Mar 31, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e40d784. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic changed the title Fix next/font usage on Windows machines Next.js: Fix next/font usage on Windows machines Apr 1, 2024
@valentinpalkovic valentinpalkovic marked this pull request as ready for review April 1, 2024 07:16
@valentinpalkovic valentinpalkovic requested a review from yannbf April 1, 2024 07:17
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 1, 2024
@valentinpalkovic valentinpalkovic merged commit b50c241 into next Apr 1, 2024
66 of 70 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-next-font-on-windows branch April 1, 2024 15:18
storybook-bot pushed a commit that referenced this pull request Apr 1, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
storybook-bot pushed a commit that referenced this pull request Apr 1, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
storybook-bot pushed a commit that referenced this pull request Apr 2, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
storybook-bot pushed a commit that referenced this pull request Apr 2, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
storybook-bot pushed a commit that referenced this pull request Apr 2, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
storybook-bot pushed a commit that referenced this pull request Apr 3, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
storybook-bot pushed a commit that referenced this pull request Apr 3, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
@sdandrader
Copy link

Hi Valentine.
I see that some checks were not succesful. ¿When this fix will be available on the last release? Thanks!

@valentinpalkovic
Copy link
Contributor Author

Hi @sdandrader,

I plan to release this fix tomorrow (8.0.6).

storybook-bot pushed a commit that referenced this pull request Apr 3, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
storybook-bot pushed a commit that referenced this pull request Apr 5, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
storybook-bot pushed a commit that referenced this pull request Apr 5, 2024
…windows

Next.js: Fix next/font usage on Windows machines

(cherry picked from commit b50c241)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal nextjs patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
3 participants