Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controls: Added server channel to create a new story #26769
Controls: Added server channel to create a new story #26769
Changes from 9 commits
12d77b8
62a9415
82121c7
51ef2d4
4dc8bf4
bc96f39
520f6cd
5cee5e7
e91c8d0
1c12bc0
5189a15
154a302
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make sense to use the value of
componentExportName
here, rather thanComponent
. Otherwise why specifycomponentExportName
at all?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
componentExportName
for a default export would bedefault
. And sincedefault
is a reserved keyword, I would suggest using a static string instead. It doesn't have to beComponent
, though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I thought
componentExportName
would be the file's base name if there is no named export. That's what the test above suggested. Either way, can we use the file's base name (converted to PascalCase) rather thanComponent
?