Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Move sharp into optional deps #26787

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

shuta13
Copy link
Contributor

@shuta13 shuta13 commented Apr 10, 2024

What I did

Fixed #25075

I referred implementations of the nextjs image optimizer for moving sharp into optional dependency.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run yarn task --task serve --start-from auto --template nextjs/13-ts serve
  2. Open Storybook in your browser
  3. Access Avif Story( The avif image is shown correctly. )

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this Apr 10, 2024
@valentinpalkovic valentinpalkovic changed the title fix: move sharp into optional deps Next.js: Move sharp into optional deps Apr 10, 2024
@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented Apr 10, 2024

Hi @shuta13

Thank you so much for your contribution! :)

I have edited the throw new Error expression to use Storybook's error framework. Otherwise, LGTM! I will try out the changes later.

Copy link

nx-cloud bot commented Apr 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3eaacff. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shuta13 shuta13 force-pushed the fix-deps-on-sharp-errors branch from 799416e to 7eec06e Compare April 11, 2024 02:23
@valentinpalkovic valentinpalkovic added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:normal labels Apr 11, 2024
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 11, 2024
@valentinpalkovic valentinpalkovic merged commit 9fd8c0a into storybookjs:next Apr 11, 2024
77 of 112 checks passed
@vanessayuenn vanessayuenn added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 11, 2024
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
12 tasks
@vanessayuenn vanessayuenn added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 11, 2024
@github-actions github-actions bot mentioned this pull request Apr 12, 2024
21 tasks
shilman pushed a commit that referenced this pull request Apr 16, 2024
Next.js: Move sharp into optional deps

(cherry picked from commit 9fd8c0a)
yannbf pushed a commit that referenced this pull request Apr 19, 2024
Next.js: Move sharp into optional deps

(cherry picked from commit 9fd8c0a)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. nextjs patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dependency on sharp in @storybook/nextjs should be optional
3 participants