Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix incorrect syntax of object in storybook-coverage-addon-config-options.ts.mdx #27029

Merged
merged 1 commit into from
May 6, 2024

Conversation

r4ai
Copy link
Contributor

@r4ai r4ai commented May 6, 2024

What I did

Fix incorrect syntax of object in storybook-coverage-addon-config-options.ts.mdx.

Checklist for Contributors

Testing

N/A

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@r4ai r4ai changed the title Docs: Fix incorrect syntax of object in storybook-coverage-addon-config-options.ts. Docs: Fix incorrect syntax of object in storybook-coverage-addon-config-options.ts.mdx May 6, 2024
@yannbf yannbf added documentation ci:docs Run the CI jobs for documentation checks only. labels May 6, 2024
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for catching this!

@yannbf yannbf enabled auto-merge May 6, 2024 13:09
@yannbf yannbf disabled auto-merge May 6, 2024 13:10
@yannbf yannbf merged commit 493679c into storybookjs:next May 6, 2024
14 of 20 checks passed
Copy link

nx-cloud bot commented May 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4f2bec7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants