-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js: Avoid conflicts with the raw loader #27093
Next.js: Avoid conflicts with the raw loader #27093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@seanparmelee Thank you for your contribution. It is much appreciated 🥳
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4993b00. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Next.js: Avoid conflicts with the raw loader (cherry picked from commit f5fc402)
Next.js: Avoid conflicts with the raw loader (cherry picked from commit f5fc402)
Next.js: Avoid conflicts with the raw loader (cherry picked from commit f5fc402)
Next.js: Avoid conflicts with the raw loader (cherry picked from commit f5fc402)
Next.js: Avoid conflicts with the raw loader (cherry picked from commit f5fc402)
Next.js: Avoid conflicts with the raw loader (cherry picked from commit f5fc402)
Next.js: Avoid conflicts with the raw loader (cherry picked from commit f5fc402)
Next.js: Avoid conflicts with the raw loader (cherry picked from commit f5fc402)
Next.js: Avoid conflicts with the raw loader (cherry picked from commit f5fc402)
@seanparmelee it seems the PR has introduced a regression to everyone, who sets up a custom @svgr loader: #27195 (comment) Can't we use the |
Sorry about that @valentinpalkovic, yes FWIW, we too are using |
@seanparmelee That would be amazing! |
Next.js: Avoid conflicts with the raw loader (cherry picked from commit f5fc402)
Closes #26991
What I did
When
@storybook/nextjs
configures the SWC loader, it updates the raw loader rule to exclude__barrel_optimize__
requests, which pertain to Next'soptimizePackageImports
feature. For example, in a project using@mui/material
, a resource may look likeand the
Drawer
here would match the/raw/
test, preventing the resource from being loaded correctly.We could also just update the raw rule accordingly, but I figured since this is specific to Next.js and SWC, I put the logic in the
configureSWCLoader
function.Checklist for Contributors
Testing
Looking for guidance on how you'd prefer this change be covered. I've tested this using a storybook that's using
@storybook/nextjs
and@mui/material
with a story that uses theDrawer
component. Would you prefer to have an integration test for this specific scenario?The changes in this PR are covered in the following automated tests:
Manual testing
There is a reproduction in #26991 (https://github.com/11bit/next-storybook-import-raw-bag) that could be used to confirm this story loads with these changes.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>