Next.js: Add typing for NextImage to main framework options type #27105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
bug
typescript
nextjs
ci:daily
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e21f7d4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ndelangen
approved these changes
May 13, 2024
yannbf
reviewed
May 13, 2024
code/frameworks/nextjs/src/types.ts
Outdated
|
|
||
| type FrameworkName = '@storybook/nextjs'; | ||
| type BuilderName = '@storybook/builder-webpack5'; | ||
|
|
||
| export type FrameworkOptions = ReactOptions & { | ||
| nextConfigPath?: string; | ||
|
|
||
| image?: NextImage.ImageProps; |
There was a problem hiding this comment.
Is this compliant with Next 13 and 14? If so, all good!
There was a problem hiding this comment.
Yes. It is Next.js 13 compatible. I've added a Partial<NextImage.ImageProps> wrapper, thought, to mark all keys as optional.
valentinpalkovic
added
the
patch:yes
storybook-bot
pushed a commit
that referenced
this pull request
May 14, 2024
…typing Next.js: Add typing for NextImage to main framework options type (cherry picked from commit 46646d2)
This was referenced May 14, 2024
Merged
storybook-bot
pushed a commit
that referenced
this pull request
May 14, 2024
…typing Next.js: Add typing for NextImage to main framework options type (cherry picked from commit 46646d2)
storybook-bot
pushed a commit
that referenced
this pull request
May 14, 2024
…typing Next.js: Add typing for NextImage to main framework options type (cherry picked from commit 46646d2)
storybook-bot
pushed a commit
that referenced
this pull request
May 14, 2024
…typing Next.js: Add typing for NextImage to main framework options type (cherry picked from commit 46646d2)
storybook-bot
pushed a commit
that referenced
this pull request
May 14, 2024
…typing Next.js: Add typing for NextImage to main framework options type (cherry picked from commit 46646d2)
storybook-bot
pushed a commit
that referenced
this pull request
May 14, 2024
…typing Next.js: Add typing for NextImage to main framework options type (cherry picked from commit 46646d2)
storybook-bot
pushed a commit
that referenced
this pull request
May 14, 2024
…typing Next.js: Add typing for NextImage to main framework options type (cherry picked from commit 46646d2)
storybook-bot
pushed a commit
that referenced
this pull request
May 15, 2024
…typing Next.js: Add typing for NextImage to main framework options type (cherry picked from commit 46646d2)
storybook-bot
pushed a commit
that referenced
this pull request
May 15, 2024
…typing Next.js: Add typing for NextImage to main framework options type (cherry picked from commit 46646d2)
storybook-bot
pushed a commit
that referenced
this pull request
May 15, 2024
…typing Next.js: Add typing for NextImage to main framework options type (cherry picked from commit 46646d2)
Closed
9 tasks
github-actions
bot
added
the
patch:done
larsrickert
pushed a commit
that referenced
this pull request
Jun 8, 2024
…typing Next.js: Add typing for NextImage to main framework options type (cherry picked from commit 46646d2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25397
What I did
I've added the
imageoption type to Next.js' framework options.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
imageoption toframeworks.options.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>