Docs: Fix MDX Stories block tag-filtering behavior #27144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27143
What I did
Made a sneaky change to the tag-based filtering of
autodocs
introduced in 8.1, which was an unintentional breaking change for users who used theStories
doc block in MDX pages.Now if NONE of the stories have the autodocs tag (which is only possible in an MDX page), it will show ALL of the stories in the
Stories
block.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
You can check the added stories:
You can also reproduce this in a sandbox by adding
Button.mdx
and playing around with the tags inButton.stories.ts
:🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>