Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update Bitovi GitHub Actions snippet #27150

Merged
merged 4 commits into from
May 23, 2024

Conversation

Girgetto
Copy link
Contributor

What I did

Updated the GitHub Actions version for bitovi/github-actions-storybook-to-github-pages from v1.0.1 to v1.0.3 in the documentation to avoid the pipeline failure associated with version v1.0.1, as described in bitovi/github-actions-storybook-to-github-pages#6.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Open Storybook in your browser
  3. Access any story to ensure it renders correctly

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fix incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@Girgetto Girgetto marked this pull request as draft May 19, 2024 13:09
@Girgetto Girgetto marked this pull request as ready for review May 19, 2024 13:09
@jonniebigodes jonniebigodes self-assigned this May 20, 2024
@jonniebigodes jonniebigodes changed the title Update GitHub Actions Version in Documentation to Prevent Pipeline Failures Docs: Update Bitovi GitHub Actions snippet May 23, 2024
@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch ci:docs Run the CI jobs for documentation checks only. labels May 23, 2024
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Girgetto appreciate you putting together this pull request and helping us improve the documentation by updating this example so that you and other developers using the action can deploy it without any issues. We appreciate it 🙏 .

All is good on my end. I'm going to merge this once the checklist clears.

Hope you have a fantastic day.

Stay safe

Copy link

nx-cloud bot commented May 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 420dd00. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jonniebigodes jonniebigodes merged commit 99882a3 into storybookjs:next May 23, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request May 23, 2024
25 tasks
storybook-bot pushed a commit that referenced this pull request May 23, 2024
Docs: Update  Bitovi GitHub Actions snippet
(cherry picked from commit 99882a3)
@github-actions github-actions bot mentioned this pull request May 23, 2024
13 tasks
storybook-bot pushed a commit that referenced this pull request May 23, 2024
Docs: Update  Bitovi GitHub Actions snippet
(cherry picked from commit 99882a3)
storybook-bot pushed a commit that referenced this pull request May 24, 2024
Docs: Update  Bitovi GitHub Actions snippet
(cherry picked from commit 99882a3)
storybook-bot pushed a commit that referenced this pull request May 24, 2024
Docs: Update  Bitovi GitHub Actions snippet
(cherry picked from commit 99882a3)
storybook-bot pushed a commit that referenced this pull request May 24, 2024
Docs: Update  Bitovi GitHub Actions snippet
(cherry picked from commit 99882a3)
storybook-bot pushed a commit that referenced this pull request May 24, 2024
Docs: Update  Bitovi GitHub Actions snippet
(cherry picked from commit 99882a3)
storybook-bot pushed a commit that referenced this pull request May 27, 2024
Docs: Update  Bitovi GitHub Actions snippet
(cherry picked from commit 99882a3)
storybook-bot pushed a commit that referenced this pull request May 27, 2024
Docs: Update  Bitovi GitHub Actions snippet
(cherry picked from commit 99882a3)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants