Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Re-enable nissuer bot #27184

Merged
merged 2 commits into from
May 17, 2024
Merged

Actions: Re-enable nissuer bot #27184

merged 2 commits into from
May 17, 2024

Conversation

vanessayuenn
Copy link
Contributor

What I did

I missed @balazsorban44's comment when merging #27160. And indeed, if the "reproduction" field is a textarea, people are encouraged to put in more than just a link, making the nissuer's regex not work properly. This PR changes the repro fields of the bug report template to ask for 1) a URL and 2) steps to reproduce if applicable.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

none needed

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

if too much text is allowed in the "repro" section, the regex for the `nissuer` bot doesn't work properly.
@vanessayuenn vanessayuenn added build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only. labels May 17, 2024
@vanessayuenn vanessayuenn requested a review from yannbf May 17, 2024 14:08
Copy link

nx-cloud bot commented May 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 88816f9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@vanessayuenn vanessayuenn merged commit d4d4603 into next May 17, 2024
17 checks passed
@vanessayuenn vanessayuenn deleted the vy/nissuer branch May 17, 2024 14:35
@github-actions github-actions bot mentioned this pull request May 17, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants