Remove polymer-cli dependency #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be used in a full example, but the polymer-cli isn't used by us, and installs gigabytes of dependencies..
Hypnosphi
approved these changes
Jan 13, 2018
|
Not related to the PR, but why don't we have |
|
@Hypnosphi we do |
|
@ndelangen can you please remove this dep from CLI fixture as well? It slows down CLI test significantly |
shilman
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2741 +/- ##
=======================================
Coverage 33.08% 33.08%
=======================================
Files 418 418
Lines 9134 9134
Branches 968 971 +3
=======================================
Hits 3022 3022
- Misses 5453 5458 +5
+ Partials 659 654 -5
Continue to review full report at Codecov.
|
…build-remove-polymer-cli # Conflicts: # yarn.lock
|
@Hypnosphi I'm not seeing the dependency anywhere else.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be used in a full example, but the polymer-cli isn't used by us, and installs gigabytes of dependencies..