Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Introducing Bun for Script Execution #28046

Closed
wants to merge 55 commits into from
Closed

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jun 6, 2024

Closes N/A

What I did

This PR introduces a significant change to our script execution process. We are now using Bun, a powerful tool for running scripts from the scripts directory. Bun provides a simple and efficient way to manage and run our scripts, improving our development workflow.

To start using Bun locally, you will need to install it. You can do this by running the following command in your terminal:

curl -fsSL https://bun.sh/install | bash

Once Bun is installed, you can run for example the yarn task command as usual.

In addition to introducing Bun, this PR also includes an update to our execa configuration. I've updated execa to the latest version and made some changes to its configuration. Please note that Bun currently does not support inheriting stdio from the main process, so we've configured execa to handle this aspect of our script execution process.

The most important work is split into the following chunks

Motivation

Previously, we used esbuild-register for on-the-fly transformation of ECMAScript modules (ESM) to CommonJS (CJS). However, we encountered a significant bug in esbuild-register when using it with newer Node.js versions (20.6.0 and above). This bug has been open for a while and doesn't seem to be getting fixed in the near future.

Moreover, the use of esbuild-register was somewhat counterproductive to our long-term goal. We plan to phase out the use of CommonJS in favor of ECMAScript modules. The on-the-fly transformation of ESM to CJS by esbuild-register was a step away from this goal.

By switching to Bun, we are not only circumventing the bug in esbuild-register, but also taking a step closer to our goal of fully adopting ECMAScript modules. Bun's built-in TypeScript support allows us to write our scripts directly in TypeScript and run them as ECMAScript modules, eliminating the need for on-the-fly transformations to CommonJS.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this Jun 6, 2024
@valentinpalkovic valentinpalkovic added ci:daily Run the CI jobs that normally run in the daily job. build Internal-facing build tooling & test updates labels Jun 6, 2024
Copy link

nx-cloud bot commented Jun 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 84d2574. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants