-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Split the CLI, forward all commands except dev and build to @storybook/toolbox #28471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Updated
code/core/src/common/versions.ts
to include@storybook/toolbox
version8.2.0-beta.0
- Modified
code/core/src/core-server/utils/warnOnIncompatibleAddons.ts
to import from@storybook/toolbox
- Adjusted dependencies and scripts in
code/lib/cli/package.json
for new CLI structure - Forwarded most CLI commands to
@storybook/toolbox
incode/lib/cli/src/generate.ts
- Added new files and configurations for
@storybook/toolbox
package incode/lib/toolbox
directory
14 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/9815353874 |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3051a5b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/9815416602 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Renamed
code/lib/cli/src/core-path.ts
andcode/lib/cli/src/index.ts
to reflect CLI split. - Deleted
code/lib/toolbox/core.cjs
,core.d.ts
, andcore.js
as part of CLI refactoring. - Updated import paths in
scripts/create-nx-sandbox-projects.ts
,scripts/event-log-checker.ts
, andscripts/get-template.ts
to use@storybook/toolbox
. - Modified
scripts/sandbox/generate.ts
,scripts/sandbox/utils/template.ts
, andscripts/task.ts
to align with new CLI structure. - Adjusted
scripts/utils/cli-step.ts
to forward all commands except 'dev' and 'build' to@storybook/toolbox
.
14 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
What I did
Implements the CLI split RFC:
#23590
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-28471-sha-3051a5b2
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-28471-sha-3051a5b2 sandbox
or in an existing project withnpx storybook@0.0.0-pr-28471-sha-3051a5b2 upgrade
.More information
0.0.0-pr-28471-sha-3051a5b2
kasper/storybook-toolbox
3051a5b2
1720232588
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28471