Core: Upgrade docs-mdx for smaller install #28552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Upgraded
@storybook/docs-mdxto4.0.0--canary.19.48b6c75.0in/code/core/package.json - Transitioned
@storybook/docs-mdxto ESM-only, removing Babel - Replaced static import with dynamic import of
analyzein/code/core/src/core-server/utils/StoryIndexGenerator.ts - Optimized loading and execution of
analyzefunction for better performance
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f4b0bb5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
force-pushed
the
shilman/optimize-docs-mdx
branch
from
be84deb to
f3530d0
Compare
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
Upgrade
@storybook/docs-mdxto an ESM-only version that no longer uses babel and runs asynchronouslyChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Fire up a sandbox and checks the docs/mdx stories
🦋 Canary release
This pull request has been released as version
0.0.0-pr-28552-sha-be84deb3. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-28552-sha-be84deb3 sandboxor in an existing project withnpx storybook@0.0.0-pr-28552-sha-be84deb3 upgrade.More information
0.0.0-pr-28552-sha-be84deb3shilman/optimize-docs-mdxbe84deb31720715280)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28552