-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Support experimental zoneless mode #28657
Angular: Support experimental zoneless mode #28657
Conversation
- Added new option to StandaloneOptions
- Added "provideExperimentalZonelessChangeDetection" provider to the render logic - Removed "zone.js" from globals
I tried to read the necessary information from the angular.json via the helper class "AngularJSON". Thanks! |
I didn’t had a chance to take a look today. I’ll take a look on Monday and I will clarify what’s unclear! Thank you for putting together the PR so far :) |
View your CI Pipeline Execution ↗ for commit 4bc2c80.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Closes #28403
What I did
zone.js
. Storybook is automatically picking up the user's polyfills. Therefore, zone.js was polyfilled twice.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
Adds support for Angular's experimental zoneless mode by introducing configuration options and modifying the framework to conditionally load zone.js, enabling improved performance and debugging capabilities.
experimentalZoneless
flag incode/frameworks/angular/src/builders/build-storybook/schema.json
andstart-storybook/schema.json
code/frameworks/angular/src/client/globals.ts
to remove mandatory zone.js importcode/frameworks/angular/src/client/angular-beta/AbstractRenderer.ts
to support conditional zoneless change detectioncode/frameworks/angular/package.json
code/frameworks/angular/src/server/framework-preset-angular-cli.ts
to expose zoneless settings💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!