Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add jiti as dev dependency to core #29173

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Sep 20, 2024

Closes #

What I did

Add jiti as a dev-dependency of the core package, so that one can simply run yarn prep in code/core, and everything is working fine (for easier testing).

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.4 MB 77.4 MB 0 B 1.74 0%
initSize 162 MB 162 MB -1.73 kB -0.21 0%
diffSize 85 MB 85 MB -1.73 kB -0.4 0%
buildSize 7.57 MB 7.57 MB 0 B -0.65 0%
buildSbAddonsSize 1.66 MB 1.66 MB 0 B -0.65 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.34 MB 2.34 MB 0 B - 0%
buildSbPreviewSize 352 kB 352 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.55 MB 4.55 MB 0 B -0.65 0%
buildPreviewSize 3.02 MB 3.02 MB 0 B -0.65 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 6.8s 19.4s 12.5s 0.66 64.6%
generateTime 21.6s 22s 417ms 1.67 1.9%
initTime 16.1s 15.6s -423ms -0.51 -2.7%
buildTime 11.1s 10.8s -289ms -0.45 -2.7%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.9s 7.9s 1s 1.4 🔺12.9%
devManagerResponsive 4.6s 5s 405ms 1.2 8%
devManagerHeaderVisible 849ms 816ms -33ms -0.1 -4%
devManagerIndexVisible 895ms 853ms -42ms -0.13 -4.9%
devStoryVisibleUncached 1.4s 1.7s 260ms 1.33 🔺15%
devStoryVisible 893ms 852ms -41ms -0.14 -4.8%
devAutodocsVisible 840ms 768ms -72ms 0.07 -9.4%
devMDXVisible 796ms 873ms 77ms 1.98 🔺8.8%
buildManagerHeaderVisible 835ms 799ms -36ms -0.21 -4.5%
buildManagerIndexVisible 837ms 802ms -35ms -0.46 -4.4%
buildStoryVisible 920ms 868ms -52ms -0.02 -6%
buildAutodocsVisible 816ms 920ms 104ms 2.06 🔺11.3%
buildMDXVisible 773ms 777ms 4ms 0.76 0.5%

Greptile Summary

This PR adds 'jiti' as a dev dependency to the @storybook/core package, enabling easier local testing for developers.

  • Added 'jiti' to devDependencies in code/core/package.json
  • Allows running 'yarn prep' in the code/core directory for streamlined testing
  • No significant changes or potential issues introduced

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Sep 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3bae5cf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen self-assigned this Sep 23, 2024
@kasperpeulen kasperpeulen added build Internal-facing build tooling & test updates ci:normal labels Sep 23, 2024
@kasperpeulen kasperpeulen changed the title Chore: Add jiti as dev dependency to core Build: Add jiti as dev dependency to core Sep 24, 2024
@kasperpeulen kasperpeulen merged commit 60e266a into storybookjs:next Sep 24, 2024
55 of 59 checks passed
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
21 tasks
@tobiasdiez tobiasdiez deleted the core-jiti branch September 25, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants