Core: Remove dependence on file-system-cache
#29256
Merged
+166
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the title
file-system-cache by embedding it into our sourcefile-system-cache
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fbf7a92. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
…kjs/storybook into norbert/replace-fscache
…the modules, instead of entrypoints...
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
8 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
Comment on lines
+17
to
+18
| content?: any; | ||
| value?: any; |
There was a problem hiding this comment.
style: Consider using a more specific type than 'any' for content and value
| } | ||
|
|
||
| public async setMany(items: CacheItem[], options?: CacheSetOptions): Promise<void> { | ||
| await Promise.all(items.map((item) => this.set(item.key, item.content ?? item.value, options))); |
There was a problem hiding this comment.
style: This could potentially cause performance issues with large numbers of items. Consider batching
Comment on lines
+139
to
+140
| .map((data) => JSON.parse(data)) | ||
| .filter((entry) => entry.content && !this.isExpired(entry, now)); |
There was a problem hiding this comment.
style: This approach might be inefficient for large caches. Consider implementing pagination or streaming
JReinhold
reviewed
Oct 3, 2024
JReinhold
approved these changes
Oct 7, 2024
6 tasks
shilman
changed the title
file-system-cachefile-system-cache
JReinhold
added
dependencies
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29168
What I did
I embeddedn
file-system-cacheinto our own source code.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-29256-sha-cd1d83f5. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-29256-sha-cd1d83f5 sandboxor in an existing project withnpx storybook@0.0.0-pr-29256-sha-cd1d83f5 upgrade.More information
0.0.0-pr-29256-sha-cd1d83f5norbert/replace-fscachecd1d83f51728298095)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29256Greptile Summary
This PR removes the dependency on
file-system-cacheand replaces it with a custom implementation embedded in the project's source code, addressing issues such as size, dependency onramda, typing problems, and versioning inconsistencies.FileSystemCacheclass incode/core/src/common/utils/file-cache.tsto replace external dependencycode/builders/builder-webpack5/src/index.tsandsrc/preview/iframe-webpack.config.tsto use new cache implementationfile-system-cachefrom dependencies incode/core/package.jsoncode/core/src/cli/dev.tsto adjust for new cache implementationcode/core/src/types/modules/core-common.tsto use local FileSystemCache type