Vue: Properly resolve Vite plugin #29795
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 517dba5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
| @@ -1,6 +1,6 @@ | |||
| import type { Plugin } from 'vite'; | |||
|
|
|||
| export async function templateCompilation() { | |||
| export async function templateCompilation(): Promise<Plugin> { | |||
There was a problem hiding this comment.
I actually don't see a reason for this to be a promise in the first place cc @yannbf ?
There was a problem hiding this comment.
There is no reason. The others were needed because they do dynamic imports, but this one seems simple enough
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 61 | 61 | 0 |
| Self size | 916 KB | 695 KB | 🎉 -221 KB 🎉 |
| Dependency size | 13.86 MB | 13.86 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
yannbf
changed the title
yannbf
added
the
patch:yes
Vue: Properly resolve Vite plugin (cherry picked from commit f25b824)
|
Thanks for the quick merge! |
github-actions
bot
added
the
patch:done
What I did
Currently, the vue preset adds
storybook:vue-template-compilationas unresolvedPromise<Plugin>. This leads to memory issues downstream as analyzed in nuxt-modules/storybook#740 (comment). This is fixed by awating the promise. Also changed the types of the plugin array to the strongerPlugintype, which doesn't admit promises to prevent this from reaccouring the future.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Fixes memory issues in Vue's Vite plugin system by properly resolving plugin promises and enforcing stricter typing for plugin arrays.
storybookVuePluginincode/frameworks/vue3-vite/src/vite-plugin.tsto properly await plugin promisesPluginOption[]to stricterPlugin[]type incode/frameworks/vue3-vite/src/preset.tstemplateCompilationfunction incode/frameworks/vue3-vite/src/plugins/vue-template.ts💡 (4/5) You can add custom instructions or style guidelines for the bot here!