Release: Prerelease 8.5.0-alpha.17 #29800
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Docs: Maintenance - Fix prettier docs script
ReactVite: Add `@storybook/test` as optional peer dependency
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
58 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -21,10 +21,10 @@ | |||
| "-e", | |||
| "json", | |||
| "-d", | |||
| "." // Add this line to introspect the relevant files starting from the root directory of your project. | |||
| ".", // Add this line to introspect the relevant files starting from the root directory of your project. | |||
There was a problem hiding this comment.
syntax: trailing comma added after comment, which could cause parsing issues in strict JSON
| import.meta.glob('./stories/**/*.(stories|story).@(js|jsx|mjs|ts|tsx)', { | ||
| eager: true, | ||
| }) | ||
| }), | ||
| ); |
There was a problem hiding this comment.
style: The glob pattern for story files should include a check for .stories.mdx files since Storybook supports MDX format
| @@ -21,7 +21,7 @@ function getAllStoryFiles() { | |||
| const storyFiles = Object.entries( | |||
| import.meta.glob('./stories/**/*.(stories|story).@(js|jsx|mjs|ts|tsx)', { | |||
There was a problem hiding this comment.
logic: path is used but not imported - this will cause runtime errors
| }), | ||
| ); |
There was a problem hiding this comment.
style: trailing comma added for consistency with other config files
…mport Vite: Fix preview runtime import
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.16
branch
from
4234f31 to
9b67312
Compare
…tomigration CLI: Fix new-frameworks automigration
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.16
branch
from
9b67312 to
5094868
Compare
yannbf
added
ci:daily
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5094868. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
This is an automated pull request that bumps the version from
8.5.0-alpha.16to8.5.0-alpha.17.Once this pull request is merged, it will trigger a new release of version
8.5.0-alpha.17.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:@storybook/testas optional peer dependency #29754If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-alpha.17
@storybook/testas optional peer dependency - #29754, thanks @yannbf!